Hanan/activate validators #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OisinKyne
reviewed
Oct 9, 2023
|
|
||
| ## Activate the DVs using the deposit contract | ||
|
|
||
| This guide will in future cover activating the deposit data from a lock file. | ||
| In order to activate cluster validator, the cluster operator can retrieve the validator associated deposit data and call deposit from the deposit contract. |
There was a problem hiding this comment.
Suggested change
| In order to activate cluster validator, the cluster operator can retrieve the validator associated deposit data and call deposit from the deposit contract. | |
| In order to activate the distributed validators, the cluster operator can retrieve the validators' associated deposit data from the lock file and use it to craft transactions to the `deposit()` method on the deposit contract. |
Comment on lines
121
to
123
| const principal = BigNumber.from(validatorDepositData.amount); // 32 ethers | ||
|
|
||
| const TX_VALUE = principal.mul(WEI_FACTOR); |
There was a problem hiding this comment.
Have you tested this? I would have thought principal coming from our API ends up being "32000000000". So multiplying by a further 18 decimals leads to too many decimals and too high a value?
I would imagine we multiply by 10 ** 9 to get the outcome we want.
Here's a calculator to help test https://eth-converter.com/
There was a problem hiding this comment.
You are right. Fixing it
| @@ -13,7 +13,7 @@ import TabItem from '@theme/TabItem'; | |||
| The Obol-SDK is in an alpha state and should be used with caution. | |||
There was a problem hiding this comment.
Suggested change
| The Obol-SDK is in an alpha state and should be used with caution. | |
| The Obol-SDK is in an alpha state and should be used with caution, particularly on mainnet. |
OisinKyne
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Activate validators section.
Screenshots
ticket:
#266